-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: command content type #143
Conversation
…endpoint to comply with keycloak api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 99.26% 99.26% -0.01%
==========================================
Files 27 27
Lines 820 816 -4
==========================================
- Hits 814 810 -4
Misses 6 6 ☔ View full report in Codecov by Sentry. |
a85e6c7
to
8b8e017
Compare
Hey @danielmaier42 maybe you can help me out here 🙂 The newly added integration test for Looking at the Keycloak docs, I can't see any parameter for the email - do you happen to know how the endpoint is supposed to be called? |
@fschmtt , the error message should be relating to the user profile. The user must have an email address assigned, otherwise you cannot execute any email actions. The request itself only has an array of actions as body, so that should be working now. 😊 Are you able to add an email address for your user on which you are testing? But afar from that it hardly depends on how far you want to go with testing. Do you want to test, that the email is actually sent? Then you would need an smtp setup as well and maybe some Mailhog Docker setup. But i guess it should be good enough for now, if you have an email assigned and the request is getting executed with an 204 as Response. |
edc4bad
to
f944a2d
Compare
f944a2d
to
f26a0a5
Compare
Thanks for clarifying! I had to set the user to enabled and set an email address. I didn't decide on how far I wanna go with integration testing; but it definitely helps to identify issues if as much as possible is covered with actual integration tests e.g. in case the Keycloak API has changed (which has happened in the past 😅). |
Closed in favor of #142 |
No description provided.