Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: command content type #143

Closed
wants to merge 4 commits into from
Closed

feat: command content type #143

wants to merge 4 commits into from

Conversation

fschmtt
Copy link
Owner

@fschmtt fschmtt commented Jan 17, 2025

No description provided.

@fschmtt fschmtt self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (ab02f04) to head (f26a0a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   99.26%   99.26%   -0.01%     
==========================================
  Files          27       27              
  Lines         820      816       -4     
==========================================
- Hits          814      810       -4     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fschmtt fschmtt changed the title Feat command content type feat: command content type Jan 17, 2025
@fschmtt fschmtt force-pushed the feat-command-content-type branch from a85e6c7 to 8b8e017 Compare January 17, 2025 10:48
@fschmtt
Copy link
Owner Author

fschmtt commented Jan 18, 2025

Hey @danielmaier42 maybe you can help me out here 🙂

The newly added integration test for Users::executeActionsEmail() is failing because the user email is missing from the request.

Looking at the Keycloak docs, I can't see any parameter for the email - do you happen to know how the endpoint is supposed to be called?

@danielmaier42
Copy link

@fschmtt , the error message should be relating to the user profile. The user must have an email address assigned, otherwise you cannot execute any email actions. The request itself only has an array of actions as body, so that should be working now. 😊

Are you able to add an email address for your user on which you are testing?

But afar from that it hardly depends on how far you want to go with testing. Do you want to test, that the email is actually sent? Then you would need an smtp setup as well and maybe some Mailhog Docker setup. But i guess it should be good enough for now, if you have an email assigned and the request is getting executed with an 204 as Response.

@fschmtt fschmtt force-pushed the feat-command-content-type branch 3 times, most recently from edc4bad to f944a2d Compare January 23, 2025 21:02
@fschmtt fschmtt force-pushed the feat-command-content-type branch from f944a2d to f26a0a5 Compare January 23, 2025 21:10
@fschmtt
Copy link
Owner Author

fschmtt commented Jan 23, 2025

Thanks for clarifying! I had to set the user to enabled and set an email address.

I didn't decide on how far I wanna go with integration testing; but it definitely helps to identify issues if as much as possible is covered with actual integration tests e.g. in case the Keycloak API has changed (which has happened in the past 😅).

@fschmtt
Copy link
Owner Author

fschmtt commented Jan 23, 2025

Closed in favor of #142

@fschmtt fschmtt closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants